mirror of
https://github.com/actions/checkout.git
synced 2026-01-11 00:19:58 +08:00
This PR fixes several issues with tag handling in the checkout action: 1. fetch-tags: true now works (fixes #1471) - Tags refspec is now included in getRefSpec() when fetchTags=true - Previously tags were only fetched during a separate fetch that was overwritten by the main fetch 2. Tag checkout preserves annotations (fixes #290) - Tags are fetched via refspec (+refs/tags/*:refs/tags/*) instead of --tags flag - This fetches the actual tag objects, preserving annotations 3. Tag checkout with fetch-tags: true no longer fails (fixes #1467) - When checking out a tag with fetchTags=true, only the wildcard refspec is used (specific tag refspec is redundant) Changes: - src/ref-helper.ts: getRefSpec() now accepts fetchTags parameter and prepends tags refspec when true - src/git-command-manager.ts: fetch() simplified to always use --no-tags, tags are fetched explicitly via refspec - src/git-source-provider.ts: passes fetchTags to getRefSpec() - Added E2E test for fetch-tags option Related #1471, #1467, #290
231 lines
7.6 KiB
TypeScript
231 lines
7.6 KiB
TypeScript
import * as assert from 'assert'
|
|
import * as refHelper from '../lib/ref-helper'
|
|
import {IGitCommandManager} from '../lib/git-command-manager'
|
|
|
|
const commit = '1234567890123456789012345678901234567890'
|
|
let git: IGitCommandManager
|
|
|
|
describe('ref-helper tests', () => {
|
|
beforeEach(() => {
|
|
git = {} as unknown as IGitCommandManager
|
|
})
|
|
|
|
it('getCheckoutInfo requires git', async () => {
|
|
const git = null as unknown as IGitCommandManager
|
|
try {
|
|
await refHelper.getCheckoutInfo(git, 'refs/heads/my/branch', commit)
|
|
throw new Error('Should not reach here')
|
|
} catch (err) {
|
|
expect((err as any)?.message).toBe('Arg git cannot be empty')
|
|
}
|
|
})
|
|
|
|
it('getCheckoutInfo requires ref or commit', async () => {
|
|
try {
|
|
await refHelper.getCheckoutInfo(git, '', '')
|
|
throw new Error('Should not reach here')
|
|
} catch (err) {
|
|
expect((err as any)?.message).toBe(
|
|
'Args ref and commit cannot both be empty'
|
|
)
|
|
}
|
|
})
|
|
|
|
it('getCheckoutInfo sha only', async () => {
|
|
const checkoutInfo = await refHelper.getCheckoutInfo(git, '', commit)
|
|
expect(checkoutInfo.ref).toBe(commit)
|
|
expect(checkoutInfo.startPoint).toBeFalsy()
|
|
})
|
|
|
|
it('getCheckoutInfo refs/heads/', async () => {
|
|
const checkoutInfo = await refHelper.getCheckoutInfo(
|
|
git,
|
|
'refs/heads/my/branch',
|
|
commit
|
|
)
|
|
expect(checkoutInfo.ref).toBe('my/branch')
|
|
expect(checkoutInfo.startPoint).toBe('refs/remotes/origin/my/branch')
|
|
})
|
|
|
|
it('getCheckoutInfo refs/pull/', async () => {
|
|
const checkoutInfo = await refHelper.getCheckoutInfo(
|
|
git,
|
|
'refs/pull/123/merge',
|
|
commit
|
|
)
|
|
expect(checkoutInfo.ref).toBe('refs/remotes/pull/123/merge')
|
|
expect(checkoutInfo.startPoint).toBeFalsy()
|
|
})
|
|
|
|
it('getCheckoutInfo refs/tags/', async () => {
|
|
const checkoutInfo = await refHelper.getCheckoutInfo(
|
|
git,
|
|
'refs/tags/my-tag',
|
|
commit
|
|
)
|
|
expect(checkoutInfo.ref).toBe('refs/tags/my-tag')
|
|
expect(checkoutInfo.startPoint).toBeFalsy()
|
|
})
|
|
|
|
it('getCheckoutInfo refs/', async () => {
|
|
const checkoutInfo = await refHelper.getCheckoutInfo(
|
|
git,
|
|
'refs/gh/queue/main/pr-123',
|
|
commit
|
|
)
|
|
expect(checkoutInfo.ref).toBe(commit)
|
|
expect(checkoutInfo.startPoint).toBeFalsy()
|
|
})
|
|
|
|
it('getCheckoutInfo refs/ without commit', async () => {
|
|
const checkoutInfo = await refHelper.getCheckoutInfo(
|
|
git,
|
|
'refs/non-standard-ref',
|
|
''
|
|
)
|
|
expect(checkoutInfo.ref).toBe('refs/non-standard-ref')
|
|
expect(checkoutInfo.startPoint).toBeFalsy()
|
|
})
|
|
|
|
it('getCheckoutInfo unqualified branch only', async () => {
|
|
git.branchExists = jest.fn(async (remote: boolean, pattern: string) => {
|
|
return true
|
|
})
|
|
|
|
const checkoutInfo = await refHelper.getCheckoutInfo(git, 'my/branch', '')
|
|
|
|
expect(checkoutInfo.ref).toBe('my/branch')
|
|
expect(checkoutInfo.startPoint).toBe('refs/remotes/origin/my/branch')
|
|
})
|
|
|
|
it('getCheckoutInfo unqualified tag only', async () => {
|
|
git.branchExists = jest.fn(async (remote: boolean, pattern: string) => {
|
|
return false
|
|
})
|
|
git.tagExists = jest.fn(async (pattern: string) => {
|
|
return true
|
|
})
|
|
|
|
const checkoutInfo = await refHelper.getCheckoutInfo(git, 'my-tag', '')
|
|
|
|
expect(checkoutInfo.ref).toBe('refs/tags/my-tag')
|
|
expect(checkoutInfo.startPoint).toBeFalsy()
|
|
})
|
|
|
|
it('getCheckoutInfo unqualified ref only, not a branch or tag', async () => {
|
|
git.branchExists = jest.fn(async (remote: boolean, pattern: string) => {
|
|
return false
|
|
})
|
|
git.tagExists = jest.fn(async (pattern: string) => {
|
|
return false
|
|
})
|
|
|
|
try {
|
|
await refHelper.getCheckoutInfo(git, 'my-ref', '')
|
|
throw new Error('Should not reach here')
|
|
} catch (err) {
|
|
expect((err as any)?.message).toBe(
|
|
"A branch or tag with the name 'my-ref' could not be found"
|
|
)
|
|
}
|
|
})
|
|
|
|
it('getRefSpec requires ref or commit', async () => {
|
|
assert.throws(
|
|
() => refHelper.getRefSpec('', ''),
|
|
/Args ref and commit cannot both be empty/
|
|
)
|
|
})
|
|
|
|
it('getRefSpec sha + refs/heads/', async () => {
|
|
const refSpec = refHelper.getRefSpec('refs/heads/my/branch', commit)
|
|
expect(refSpec.length).toBe(1)
|
|
expect(refSpec[0]).toBe(`+${commit}:refs/remotes/origin/my/branch`)
|
|
})
|
|
|
|
it('getRefSpec sha + refs/pull/', async () => {
|
|
const refSpec = refHelper.getRefSpec('refs/pull/123/merge', commit)
|
|
expect(refSpec.length).toBe(1)
|
|
expect(refSpec[0]).toBe(`+${commit}:refs/remotes/pull/123/merge`)
|
|
})
|
|
|
|
it('getRefSpec sha + refs/tags/', async () => {
|
|
const refSpec = refHelper.getRefSpec('refs/tags/my-tag', commit)
|
|
expect(refSpec.length).toBe(1)
|
|
expect(refSpec[0]).toBe(`+refs/tags/my-tag:refs/tags/my-tag`)
|
|
})
|
|
|
|
it('getRefSpec sha + refs/tags/ with fetchTags', async () => {
|
|
// When fetchTags is true, only include tags wildcard (specific tag is redundant)
|
|
const refSpec = refHelper.getRefSpec('refs/tags/my-tag', commit, true)
|
|
expect(refSpec.length).toBe(1)
|
|
expect(refSpec[0]).toBe('+refs/tags/*:refs/tags/*')
|
|
})
|
|
|
|
it('getRefSpec sha + refs/heads/ with fetchTags', async () => {
|
|
// When fetchTags is true, include both the branch refspec and tags wildcard
|
|
const refSpec = refHelper.getRefSpec('refs/heads/my/branch', commit, true)
|
|
expect(refSpec.length).toBe(2)
|
|
expect(refSpec[0]).toBe('+refs/tags/*:refs/tags/*')
|
|
expect(refSpec[1]).toBe(`+${commit}:refs/remotes/origin/my/branch`)
|
|
})
|
|
|
|
it('getRefSpec sha only', async () => {
|
|
const refSpec = refHelper.getRefSpec('', commit)
|
|
expect(refSpec.length).toBe(1)
|
|
expect(refSpec[0]).toBe(commit)
|
|
})
|
|
|
|
it('getRefSpec unqualified ref only', async () => {
|
|
const refSpec = refHelper.getRefSpec('my-ref', '')
|
|
expect(refSpec.length).toBe(2)
|
|
expect(refSpec[0]).toBe('+refs/heads/my-ref*:refs/remotes/origin/my-ref*')
|
|
expect(refSpec[1]).toBe('+refs/tags/my-ref*:refs/tags/my-ref*')
|
|
})
|
|
|
|
it('getRefSpec unqualified ref only with fetchTags', async () => {
|
|
// When fetchTags is true, skip specific tag pattern since wildcard covers all
|
|
const refSpec = refHelper.getRefSpec('my-ref', '', true)
|
|
expect(refSpec.length).toBe(2)
|
|
expect(refSpec[0]).toBe('+refs/tags/*:refs/tags/*')
|
|
expect(refSpec[1]).toBe('+refs/heads/my-ref*:refs/remotes/origin/my-ref*')
|
|
})
|
|
|
|
it('getRefSpec refs/heads/ only', async () => {
|
|
const refSpec = refHelper.getRefSpec('refs/heads/my/branch', '')
|
|
expect(refSpec.length).toBe(1)
|
|
expect(refSpec[0]).toBe(
|
|
'+refs/heads/my/branch:refs/remotes/origin/my/branch'
|
|
)
|
|
})
|
|
|
|
it('getRefSpec refs/pull/ only', async () => {
|
|
const refSpec = refHelper.getRefSpec('refs/pull/123/merge', '')
|
|
expect(refSpec.length).toBe(1)
|
|
expect(refSpec[0]).toBe('+refs/pull/123/merge:refs/remotes/pull/123/merge')
|
|
})
|
|
|
|
it('getRefSpec refs/tags/ only', async () => {
|
|
const refSpec = refHelper.getRefSpec('refs/tags/my-tag', '')
|
|
expect(refSpec.length).toBe(1)
|
|
expect(refSpec[0]).toBe('+refs/tags/my-tag:refs/tags/my-tag')
|
|
})
|
|
|
|
it('getRefSpec refs/tags/ only with fetchTags', async () => {
|
|
// When fetchTags is true, only include tags wildcard (specific tag is redundant)
|
|
const refSpec = refHelper.getRefSpec('refs/tags/my-tag', '', true)
|
|
expect(refSpec.length).toBe(1)
|
|
expect(refSpec[0]).toBe('+refs/tags/*:refs/tags/*')
|
|
})
|
|
|
|
it('getRefSpec refs/heads/ only with fetchTags', async () => {
|
|
// When fetchTags is true, include both the branch refspec and tags wildcard
|
|
const refSpec = refHelper.getRefSpec('refs/heads/my/branch', '', true)
|
|
expect(refSpec.length).toBe(2)
|
|
expect(refSpec[0]).toBe('+refs/tags/*:refs/tags/*')
|
|
expect(refSpec[1]).toBe(
|
|
'+refs/heads/my/branch:refs/remotes/origin/my/branch'
|
|
)
|
|
})
|
|
})
|